[ User ] Login

Bug 107: CLOSED

SpaceFM package broken by modification to call /bin/sh

Date: 2014-01-08 22:09 - Creator: slo.sleuth - Priority standard - 3 messages

SpaceFM 0.9.2 package has been modified from original source to call
the /bin/sh shell instead of /bin/bash. While this was likely done to remove
the bash dependency and keep Slitaz small, it breaks core SpaceFM functionality
as it was designed to work with bash 4.

Affected package(s): spacefm


By: OmegaPhil on 2014-01-09 21:46

I'm a SpaceFM programmer and I can confirm that bash is not an optional dependency... its used all over the place as a critical component.

 pkgs.slitaz.org/search.sh?receipt=spacefm version=cooking appears to be a callous hack to drop the dependency for appearences' sake - please be more careful when doing such things in the future - actually read the code before you try to break its assumptions.

I'm not sure how much coverage SliTaz has, but there is concern that users will try this package and seeing random failures will conclude SpaceFM is junk.

If you need more detail, see from the main programmer himself: https://github.com/IgnorantGuru/spacefm/issues/413#issuecomment-31879187 (from the bug the OP raised before this one).

By: OmegaPhil on 2014-01-09 21:47

Breaking the link :/

 pkgs.slitaz.org/search.sh?receipt=spacefm version=cooking

By: pankso on 2014-04-25 12:29

So, added bash as dep:  hg.slitaz.org/wok/rev/db124a8e80fe

This close the bug and this bash dep make us switcj to PCmanFM as default file